-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add script to automatically publish readme to docker hub #6118
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Meet Soni <meetsoni3017@gmail.com>
Signed-off-by: Meet Soni <meetsoni3017@gmail.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6118 +/- ##
==========================================
- Coverage 96.48% 96.41% -0.07%
==========================================
Files 352 352
Lines 19973 20007 +34
==========================================
+ Hits 19270 19289 +19
- Misses 520 533 +13
- Partials 183 185 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Meet Soni <meetsoni3017@gmail.com>
Signed-off-by: Meet Soni <meetsoni3017@gmail.com>
Signed-off-by: Meet Soni <meetsoni3017@gmail.com>
Signed-off-by: Meet Soni <meetsoni3017@gmail.com>
As for the quay.io - I wanted to get satisfactory result with the docker to get started with this PR, I'll look into it now. Unrelated to this PR - |
Signed-off-by: Meet Soni <meetsoni3017@gmail.com>
@@ -127,6 +129,10 @@ docker buildx build --output "${PUSHTAG}" ${target_arg} ${base_debug_img_arg} \ | |||
echo "::endgroup::" | |||
echo "Finished building${upload_comment} ${component_name} ==============" | |||
|
|||
if [[ "$upload_success" == "Y" ]]; then | |||
bash scripts/upload-docker-readme.sh "${component_name}" "${dir_arg}"/README.md |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: enclose in echo group as below, to collapse the logs
Signed-off-by: Meet Soni <meetsoni3017@gmail.com>
|
Which problem is this PR solving?
Fixes: #3842
Description of the changes
How was this change tested?
Checklist
jaeger
:make lint test